馃悰 fix: update workflows - #335
Open
jschoone wants to merge 4 commits into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Signed-off-by: Jan Schoone <6106846+jschoone@users.noreply.github.com>
Signed-off-by: Jan Schoone <6106846+jschoone@users.noreply.github.com>
Signed-off-by: Jan Schoone <6106846+jschoone@users.noreply.github.com>
Signed-off-by: Kurt Garloff <kurt@garloff.de>
Copy link
Copy Markdown
Member
|
Ah, this supercedes #339. Too bad I had not seen this one, sorry. So I merged ... |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Code QL reports that verify shellcheck is risky... Step 1 Uses Step (Source).github/workflows/pr-verify.yml:18 - name: Checkout repository
uses: actions/checkout@08eba0b27e820071cde6df949e0beb9ba4906955 # v4.3.0
with:
ref: ${{ github.event.pull_request.head.sha }}
- name: Verify Shellcheck
run: make verify-shellcheck
Step 2 Run Step (Sink).github/workflows/pr-verify.yml:23 - name: Verify Shellcheck
run: make verify-shellcheck
Potential cache poisoning in the context of the default branch due to privilege checkout of untrusted code. (pull_request_target). |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
The other question is whether we want to allow :seedling: instead of 馃尡 etc? |
Sorry, something went wrong.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs: