Impement advanced CFL reachability algorithm and optimization matrix - #5
Impement advanced CFL reachability algorithm and optimization matrix#5homka122 wants to merge 161 commits into
Conversation
Sorry, something went wrong.
|
Sorry, something went wrong.
gsvgit
left a comment
There was a problem hiding this comment.
Cosmetic.
Sorry, something went wrong.
|
|
||
| if (matrix->block_type == VEC_VERT) { | ||
| // fix: change to lagraph malloc | ||
| GrB_Index *nrows = malloc(matrix->nvals * sizeof(GrB_Index)); |
There was a problem hiding this comment.
Fix.
Sorry, something went wrong.
| Matrix *left = swap ? second : first; | ||
| Matrix *right = swap ? first : second; | ||
|
|
||
| // CFL_matrix_update(first); |
There was a problem hiding this comment.
Can be removed?
Sorry, something went wrong.
| } | ||
|
|
||
| if (output != first) { | ||
| // fprintf(stderr, "Matrix wise currently support only iadd operation"); |
There was a problem hiding this comment.
Can be removed?
Sorry, something went wrong.
|
|
||
| if ((output->block_type == CELL && mask->block_type != CELL) || | ||
| (output->block_type != CELL && mask->block_type == CELL)) { | ||
| // fprintf(stderr, "Don't support rsub operation between cell and vector"); |
There was a problem hiding this comment.
Can be removed?
Sorry, something went wrong.
| return GrB_SUCCESS; | ||
| } | ||
|
|
||
| // utility methods |
There was a problem hiding this comment.
Can be removed?
Sorry, something went wrong.
| //------------------------------------------------------------------------------ | ||
|
|
||
| // Code is based on the "A matrix-based CFPQ algorithm" described in the | ||
| // following paper: * Rustam Azimov, Semyon Grigorev, "Context-Free Path |
There was a problem hiding this comment.
Is advanced version directly based on PhD of Rustam Azimov?
Sorry, something went wrong.
| } \ | ||
| } | ||
|
|
||
| #define TRY_I(GrB_method) \ |
There was a problem hiding this comment.
What does I mean?
Sorry, something went wrong.
|
|
||
| (*symbols)[(*size)++] = sym; | ||
| checked[i] = true; | ||
| // printf("Inserted (%ld, %ld, %ld)\n", sym.index, sym.base_index, sym.count); |
There was a problem hiding this comment.
Can be removed?
Sorry, something went wrong.
Implemented the CFL Reachability algorithm based on Ilya Muravyov’s approach.
Separated and refactored all optimizations into a seperate file.
Added the core algorithm implementation and comprehensive tests with 100% coverage.