Allow custom TicketTypes to be created by plugins. - #2453
Merged
aromaa merged 4 commits intoMay 18, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
aromaa
force-pushed
the
feature/custom-ticket-types
branch
from
3dd0482 to
3bf10f8
Compare
May 4, 2024 21:58
aromaa
marked this pull request as ready for review
May 4, 2024 22:01
- Remove TicketTypes from being in the registry. They are not within the registry whatsoever in the base game nor is a resource id required to create them. Thus being impossible to maintain that contract Signed-off-by: Chris Sanders <zidane@spongepowered.org>
Signed-off-by: Chris Sanders <zidane@spongepowered.org>
aromaa
force-pushed
the
feature/custom-ticket-types
branch
from
3bf10f8 to
aa4b970
Compare
May 17, 2024 16:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SpongeAPI | Sponge
registry whatsoever in the base game nor is a resource id required to
create them. Thus being impossible to maintain that contract
Signed-off-by: Chris Sanders zidane@spongepowered.org