FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update/1.20.6 by Faithcaio · Pull Request #2501 · SpongePowered/SpongeAPI · GitHub

/ SpongeAPI Public

Update/1.20.6 - #2501

Merged
ImMorpheus merged 13 commits into
api-11from
update/1.20.6
May 15, 2024
ConversationCommits (13)ChecksFiles changed
Merged

Update/1.20.6#2501
ImMorpheus merged 13 commits into
api-11from
update/1.20.6

Conversation

Faithcaio commented May 4, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

SpongeAPI | Sponge

Faithcaio changed the base branch from api-10 to api-11 May 4, 2024 21:08
Faithcaio mentioned this pull request May 4, 2024
Merged
ImMorpheus and others added 7 commits May 4, 2024 23:14
Bump java to 21
0e9b339
Update README
c60ba1e
Update supported source version to release 21
baf5059
Set genEventImpl compatibility to java 17 for now
41b0b0c
WIP work EngineConnection
a459a98
Changes for WorldTypeTemplate.
c4161ec 
- Expose and unify the data properties between WorldType and
  WorldTypeTemplate

- Remove the type getter from template. This prompts a much larger
  discussion about data packs but templates should never reference their
  actual built type. It is an implementation detail and the API should
  declare these as temporary, lifecycle-like objects.

Signed-off-by: Chris Sanders <zidane@spongepowered.org>
We'll allow api-10 to not be broke.
56a41b9 
This needs a far better fix in 11 but that comes with looking over DataPack objects as a whole.

Signed-off-by: Chris Sanders <zidane@spongepowered.org>

Yeregorix commented May 13, 2024

Copy link
Copy Markdown
Member

Instead of having :
EngineConnectionState
EngineConnectionIntentState
EngineConnectionLoginState
EngineConnectionConfigurationState
EngineConnectionGameState
Shouldn't we have :
EngineConnectionState
EngineConnectionState.Intent
EngineConnectionState.Login
EngineConnectionState.Configuration
EngineConnectionState.Game
?
Same for ClientConnectionState and ServerConnectionState.

Also why have EngineConnectionStates (all the constants) ?

aromaa commented May 13, 2024

Copy link
Copy Markdown
Member

Yes, thanks.

The constants are for the Channels, thats kinda how it was and I just kept the same idea.

Yeregorix reviewed May 14, 2024
View reviewed changes
Comment thread src/main/java/org/spongepowered/api/network/ServerConnectionState.java
* Gets the connection latency. This is constantly calculated by the server.
*
* @return The latency
* Represents an authenicated state between a minecraft client and server.

Yeregorix May 14, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

still typo, authenicated is missing a t

ImMorpheus marked this pull request as ready for review May 15, 2024 14:36
ImMorpheus merged commit 5f93bbb into api-11 May 15, 2024
ImMorpheus deleted the update/1.20.6 branch May 15, 2024 14:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Yeregorix Yeregorix left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL