Add Viewer#sendBlockProgress - #2513
Conversation
Sorry, something went wrong.
| * @param y The y position | ||
| * @param z The z position | ||
| */ | ||
| void resetBlockProgress(int x, int y, int z); |
There was a problem hiding this comment.
This is leaking impl details, please remove this method
Sorry, something went wrong.
There was a problem hiding this comment.
Wdym it's impl detail. It's must have method if we make limits (from 0 to 1) for progress arg in sendBlockProgress
Sorry, something went wrong.
There was a problem hiding this comment.
The server doesn't need any knowledge of the current progress. This is leaking impl details by forcing implmentations to track the progress
Sorry, something went wrong.
There was a problem hiding this comment.
Server doesn't have any knowledge of the current progress. It resets only progress that was sent by sendBlockProgress() so the only knowledge server has is that some plugins used sendBlockProgress()
Sorry, something went wrong.
There was a problem hiding this comment.
I think resetBlockProgress is necessary because we need a way to remove the crack.
Notes:
- setting progress to 0 does not remove, it just means you began cracking the block.
- as discussed on discord, we will not track progress, however we need to keep somewhere a map of blockpos to destruction id
Sorry, something went wrong.
SpongeAPI | Sponge