introduce scoped registry holder using PhaseTracker - #2584
Merged
Faithcaio merged 1 commit intoMar 29, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Server DefaultedRegistryTypes should probably use scoped registry holder as well |
Sorry, something went wrong.
Faithcaio
force-pushed
the
feature/scopedregistryholder
branch
from
4bd89eb to
53b9cfe
Compare
March 27, 2025 17:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SpongeAPI | Sponge
Adds RegistryKey#asScopedReference
and RegistryType#asScopedType
which uses the current Cause to determine an appropiate RegistryHolder
if none is found it falls back to Server if available else to Game
This allows early access to registries available after Game but before Server.
E.g. EnchantmentTypes during registration for recipes.