Add SignalAwareVolume - #2594
Open
MrHell228 wants to merge 5 commits into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
gabizou
reviewed
Dec 16, 2025
| public interface SignalAwareVolume extends PrimitiveGameVolume { | ||
|
|
||
| /** | ||
| * Returns whether the given position can conduct the signal. |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Is there any implicit direction being mentioned here? Does direction actually matter in this case?
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SpongeAPI | Sponge
Adds volume that allows getting redstone signal.
There are 4 different ways of getting this signal from a block and each of them has a set of similar methods.
So I think the most sane way would be to add registry with those SignalTypes.
The only exception is that analog signal doesn't support direction-based ouput so in impl passed direction is ignored.