FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix windows build CI by brunoenten · Pull Request #152 · SpotlightKid/python-rtmidi · GitHub

/ python-rtmidi Public

fix windows build CI - #152

Merged
brunoenten merged 3 commits into
masterfrom
develop
Jun 12, 2023
ConversationCommits (3)ChecksFiles changed
Merged

fix windows build CI#152
brunoenten merged 3 commits into
masterfrom
develop

Conversation

brunoenten commented Jun 12, 2023

Copy link
Copy Markdown
Collaborator

No description provided.

brunoenten merged commit 8245ca1 into master Jun 12, 2023
SpotlightKid reviewed Jun 12, 2023
View reviewed changes
Comment thread src/_rtmidi.pyx
__all__ = (
'API_UNSPECIFIED', 'API_MACOSX_CORE', 'API_LINUX_ALSA', 'API_UNIX_JACK',
'API_WINDOWS_MM', 'API_RTMIDI_DUMMY', 'ERRORTYPE_DEBUG_WARNING',
'API_WINDOWS_MM', 'API_RTMIDI_DUMMY', 'API_WEB_MIDI', 'ERRORTYPE_DEBUG_WARNING',

SpotlightKid Jun 12, 2023

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think this change should warrant a minor version number increase.

brunoenten Jun 12, 2023

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm not sure it's actually usable 'tho

SpotlightKid reviewed Jun 12, 2023
View reviewed changes
Comment thread .github/workflows/tests.yml
Comment on lines +6 to +9
- improve-build
pull_request:
branches:
- rtmidi-5.0.0
- improve-build

SpotlightKid Jun 12, 2023

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Something doesn't seem right here. Does this belong in the master branch?

brunoenten Jun 12, 2023

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I used this file to test workflow changes. I guess we can delete it now.

SpotlightKid commented Jun 12, 2023

Copy link
Copy Markdown
Owner

The upload_pypi step was failing due to environment protection rules. I added *.*.* as a pattern for branches allowed to trigger a deployment, since release tags have the form X.Y.Z, and re-triggered the action, which then succeeded, successfully uploading the release to PyPI.

Tbh, I don't fully understand the details myself.

brunoenten deleted the develop branch June 13, 2023 06:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

SpotlightKid SpotlightKid left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL