V2.2.0 - #47
V2.2.0#47MarlonHeiber wants to merge 50 commits into
Conversation
Sorry, something went wrong.
Co-authored-by: Eugen C. <1533818+armab@users.noreply.github.com>
…m-github into repositoryActions
Repository actions
Create branch action
git-subtree-dir: lint-configs git-subtree-split: 4696badf397dfee865b76eddd0f5d9410ed5f80a
adding missing actions :)
adding missing actions :)
cognifloyd
left a comment
There was a problem hiding this comment.
What is the purpose of 7788189 ?
I believe CI clones the lint-configs repo, so I'm concerned this will get out of date. Could we remove lint-configs/?
Sorry, something went wrong.
amanda11
left a comment
There was a problem hiding this comment.
I've requested some changes on the yaml files, not had chance to check code in detail - but noticed some discrepancies on the yaml files.
We could move to using python3 f-strings to simplify formatting of the strings rather than using .format etc, but that's just a suggestion - something we can now use now that we've dropped python2 support.
Sorry, something went wrong.
| default: "{{action_context.api_user|default(None)}}" | ||
| owner: | ||
| type: "string" | ||
| description: "The account owner of the repository. The name is not case sensitive.." |
There was a problem hiding this comment.
| description: "The account owner of the repository. The name is not case sensitive.." | |
| description: "The account owner of the repository. The name is not case sensitive." |
Sorry, something went wrong.
| # Repository parameters | ||
| owner: | ||
| type: "string" | ||
| description: "The account owner of the repository. The name is not case sensitive.." |
There was a problem hiding this comment.
| description: "The account owner of the repository. The name is not case sensitive.." | |
| description: "The account owner of the repository. The name is not case sensitive." |
Sorry, something went wrong.
| description: > | ||
| Add or update repository team. | ||
| Example: | ||
| st2 run github.add_update_repository_team organization="organization" owner="owner" repo="reponame" team_slug="team_id" api_user="token_name" |
There was a problem hiding this comment.
This example uses a parameter called organization, but the yaml states that the parameter is called org.
Sorry, something went wrong.
| description: > | ||
| Add or update a repository environment. | ||
| Example: | ||
| st2 run github.add_update_repository_environment organization="organization" owner="owner" repo="reponame" reviewers="< array of reviewers >" api_user="token_name" |
There was a problem hiding this comment.
I can't see a parameter organization in the yaml. It looks like in the python code, that owner is being passed as organisation to the get_team_id - so that parameters in the example and the yaml don't seem to match.
Also yaml says environment is required parameter with no default, yet its not used in the example.
Sorry, something went wrong.
There was a problem hiding this comment.
thanks! I have rewritten this and tested the call, it seems to be okay now :)
still pending to push the code though
Sorry, something went wrong.
| github_type: | ||
| type: "string" | ||
| description: "The type of github installation to target, if unset will use the configured default." | ||
| default: ~ |
There was a problem hiding this comment.
Why is default "~" - should this have been one of enterprise or online?
Sorry, something went wrong.
There was a problem hiding this comment.
that's a good question! it's been like that since before.. I have pushed a commit to align all github_type usage and doc.
it is not required, and it can only be enterprise/online.. the default being whatever is configured in the pack, which is online by default
Sorry, something went wrong.
| required: true | ||
| api_user: | ||
| type: "string" | ||
| description: "The" |
There was a problem hiding this comment.
I think the description for api_user hasn't been finished, as its just "The"
Sorry, something went wrong.
| github_type: | ||
| type: "string" | ||
| description: "The type of github installation to target, if unset will use the configured default." | ||
| default: ~ |
There was a problem hiding this comment.
Why is default for github_type ~ rather than one of enterprise or online.
Sorry, something went wrong.
| required: false | ||
| api_user: | ||
| type: "string" | ||
| description: "The" |
There was a problem hiding this comment.
Description for api_user not complete, as its just "The"
Sorry, something went wrong.
| github_type: | ||
| type: "string" | ||
| description: "The type of github installation to target, if unset will use the configured default." | ||
| default: ~ |
There was a problem hiding this comment.
Why is default ~ rather than enterprise or online?
Sorry, something went wrong.
Co-authored-by: Amanda McGuinness <amanda.mcguinness@ammeon.com>
|
hi @amanda11 ! thanks a lot for validating all the changes :) i have gone through all of them and fixed them to my best knowledge.. also tried to run all example cases within the action description and they all seem fine now! I would like to add test cases for the actions but I guess that could be tackled in another moment cheers! |
Sorry, something went wrong.
No description provided.