FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Pack 2.1.2 - fix merge_pull action by igcherkaev · Pull Request #49 · StackStorm-Exchange/stackstorm-github · GitHub

Repository navigation

Pack 2.1.2 - fix merge_pull action - #49

Merged
cognifloyd merged 4 commits into
StackStorm-Exchange:masterfrom
copartit-src:master
Sep 7, 2022
Merged

cognifloyd merged 4 commits into
StackStorm-Exchange:masterfrom
copartit-src:master

Conversation

Copy link
Copy Markdown
Contributor

Based on github API documentation: https://docs.github.com/en/rest/pulls/pulls#get-a-pull-request

The value of the mergeable attribute can be true, false, or null. If the value is null, then GitHub has started a background job to compute the mergeability. After giving the job time to complete, resubmit the request. When the job finishes, you will see a non-null value for the mergeable attribute in the response. If mergeable is true, then merge_commit_sha will be the SHA of the test merge commit.

The if condition to test if PR is mergeable was wrong. This PR is to fix it.

CLAassistant commented Sep 7, 2022 •
edited
Loading

Copy link
Copy Markdown


All committers have signed the CLA.

cognifloyd merged commit 0e4d1e9 into StackStorm-Exchange:master Sep 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL