Update get_user.yaml default parameter for token - #55
Merged
arm4b merged 1 commit intoSep 15, 2023
Merged
arm4b merged 1 commit into
arm4b merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Update CHANGES.md Update CHANGES.md Update pack.yaml pack version
arm4b
approved these changes
Sep 15, 2023
arm4b
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks for the fix!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #54
When calling this action without a token_user and without an action_context.api_user, the default parameter specified is for some reason being evaluated into a string "None" instead of the None object.
This causes the code block for "if token_user:" here: https://github.com/dalarsen/stackstorm-github/blob/master/actions/get_user.py#L12 to be evaluated as True and causes it to run the _change_to_user_token method to be run when it aught not be (in my organization, it leads to an unauthenticated request and causes it to crash, though I imagine this wouldn't universally be the consequence of this).