Modification in the descriptions and actions along with tests. - #30
Open
ankitaOrch wants to merge 8 commits into
Open
ankitaOrch wants to merge 8 commits into
ankitaOrch wants to merge 8 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
|
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the descriptions of all parameters in the pack that take a JSON input to use double-quotes. The descriptions currently give examples with single-quotes, which do not work in the ST2 UI.
Also, Insert, Update, and Delete actions in the SQL pack only search the 'dbo' schema. Added schema parameter to support different schemas in the actions and modified to accommodate triggers.
Also modified the tests to accommodate the schema change.