Fixing the string replacement in the helm chart to update the tag instead of the image - #144
Conversation
Sorry, something went wrong.
…tead of the image
|
All contributors have signed the CLA ✍️ ✅ |
Sorry, something went wrong.
|
I have read the CLA Document and I hereby sign the CLA |
Sorry, something went wrong.
There was a problem hiding this comment.
Pull request overview
Fixes update_file so Helm chart-style image maps (e.g., {repository: ..., tag: ...}) get their tag updated instead of replacing the entire image field, and adds tests to validate the behavior.
Changes:
- Update update_file logic to write .tag when the target field is a map containing tag or repository.
- Add an integration-style Bats test that exercises the behavior with a real yq.
- Add a shared test helper to skip integration tests when yq isn’t available.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| scripts/lib/gitops-functions.sh | Adjusts map detection logic to update .tag when the map looks like an image map (tag/repository). |
| tests/lib-gitops-functions.bats | Renames/extends tests and adds a real-yq integration test for repository-only maps. |
| tests/test_helper/setup.bash | Adds skip_if_no_yq helper for conditional integration testing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Type of Change
Description
The action would currently still replace the image and not the tag.
Added some tests using the right yq and not a mocked one to verify the behavior.
Checklist