DRAFT Initial support with bad product idea for StreamDeck+XL - #9
Open
jeinstei wants to merge 1 commit into
Open
jeinstei wants to merge 1 commit into
jeinstei wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
This will also require some changes in the app itself, as I think some stuff for the screen bar is hard coded (resolution and stuff) - at least for the UI. |
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
@Core447 do you want me to work up a toy PR similarly for the main app? Or instead just wait for someone else? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Sure, go ahead if you want. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A PR to add support for the StreamDeck+XL. Should just need the proper product ID and I am guessing it will work. Subclassing StreamDeckPlus and assuming the same key and touchscreen resolutions, behaviors, etc.....this is not a guarantee. I do not have one of these. Tasks to check:
None of the other libraries seem to have support for this yet, so nothing to check against (e.g. https://github.com/OpenActionAPI/rust-elgato-streamdeck)