FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

add -s flag to include error code by braver · Pull Request #51 · SublimeLinter/SublimeLinter-phpcs · GitHub

add -s flag to include error code - #51

Merged
braver merged 3 commits into
masterfrom
error-codes
Sep 5, 2020
Merged

add -s flag to include error code#51
braver merged 3 commits into
masterfrom
error-codes

Conversation

braver commented Jun 6, 2020

Copy link
Copy Markdown
Member

Granted, the error codes are a bit long...

and capture it in the regex
braver requested a review from kaste June 6, 2020 20:52

kaste commented Jun 6, 2020

Copy link
Copy Markdown
Member

More than 40 chars is excessive. Do you think people will appreciate that change?

braver commented Jun 6, 2020

Copy link
Copy Markdown
Member Author

I would 😅 it’s kinda nice to be able find the error codes easily. Anyway, I can probably make it optional, but then our nice ignore feature won’t work on a per-code basis unless you enable it.

braver commented Jun 7, 2020

Copy link
Copy Markdown
Member Author

Regexes are stupid. We should have tests for these things...

Anyway, this should allow users to enable the error codes by add -s to the args, but leave it unchanged otherwise.

braver commented Sep 5, 2020

Copy link
Copy Markdown
Member Author

I've been using this for ages and it works. Enabling capture of the error code, and thereby enabling quick actions, is super useful.

braver merged commit 9bfdf22 into master Sep 5, 2020

kaste commented Sep 5, 2020

Copy link
Copy Markdown
Member

Yeah sure; don't forget to release. A short message would be nice so users actually know about this feature.

kaste deleted the error-codes branch September 5, 2020 19:41

braver commented Sep 5, 2020

Copy link
Copy Markdown
Member Author

My mind wandered and I was indeed about to forget all about it 🙄

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL