Allow a way to set filterName and filterPattern when creating a Subscription filter - #224
Open
cmavromichalis wants to merge 1 commit into
Open
Allow a way to set filterName and filterPattern when creating a Subscription filter#224cmavromichalis wants to merge 1 commit into
cmavromichalis wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
cmavromichalis
commented
Sep 22, 2025
Comment thread
loggroup-lambda-connector/src/loggroup-lambda-connector.js
Comment on lines
+202
to
+203
| var filterName = env.FILTER_NAME | ||
| var filterPattern = env.FILTER_PATTERN |
Copy link
Copy Markdown
Author
There was a problem hiding this comment.
I'm not sure if these should also be validated with validateRegex or validated a different way?
Sorry, something went wrong.
Comment thread
loggroup-lambda-connector/src/loggroup-lambda-connector.js
Comment on lines
+115
to
+116
| var filterName = process.env.FILTER_NAME | ||
| var filterPattern = process.env.FILTER_PATTERN |
Copy link
Copy Markdown
Author
There was a problem hiding this comment.
I'm not sure if these should also be validated with validateRegex or validated a different way?
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #165
It looks like filterName and filterPattern are stubbed out to be SumoLGLBDFilter and an empty string respectively in the function createSubscriptionFilter in loggroup-lambda-connector/src/loggroup-lambda-connector.js.
I think this was done because PutSubscriptionFilter requires these arguments.
I would like a way to set filterName and filterPattern to something other than what is hard coded here. I think we can do this the same way LOG_GROUP_PATTERN or LOG_GROUP_TAGS is provided.
My changes are an attempt to move the hard coded values into parameters so they can be overridden if desired.
I would appreciate help and guidance with this.