FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs(): socket update to 0.8+ recipe by maciejkorsan · Pull Request #135 · Syncano/syncano-node · GitHub

/ syncano-node Public

docs(): socket update to 0.8+ recipe - #135

Merged
maciejkorsan merged 2 commits into
masterfrom
docs/cookbook-socket-update
Feb 13, 2018
ConversationCommits (2)ChecksFiles changed
Merged

docs(): socket update to 0.8+ recipe#135
maciejkorsan merged 2 commits into
masterfrom
docs/cookbook-socket-update

Conversation

maciejkorsan commented Feb 9, 2018

Copy link
Copy Markdown
Member

No description provided.

maciejkorsan requested a review from mkucharz February 9, 2018 13:19
mkucharz requested changes Feb 9, 2018
View reviewed changes
Comment thread docs/cookbook/web/basics/update.md
yarn --production

```

mkucharz Feb 9, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

too much space?

Comment thread docs/cookbook/web/basics/update.md Outdated
#!/usr/bin/env sh

mkdir -p .dist
babel src --out-dir .dist/src --copy-files

mkucharz Feb 9, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

here we should have npx I think

Comment thread docs/cookbook/web/basics/update.md Outdated
mkdir -p .dist
cp package.json .dist
cd .dist
yarn --production

mkucharz Feb 9, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

maybe we should use npm instead yarn?

maciejkorsan Feb 9, 2018

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

it doesn't work if i change it to npm

mkucharz Feb 12, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@maciejkorsan you need npm install (which is default in yarn)

Comment thread docs/cookbook/web/basics/update.md Outdated

```js
"scripts": {
"build": "yarn && yarn run build:src && yarn run build:env",

mkucharz Feb 9, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

yarn is not dependency anymore so maybe we should use npm?

codecov-io commented Feb 9, 2018 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #135 into master will decrease coverage by 2.55%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #135      +/-   ##
=========================================
- Coverage   37.46%   34.9%   -2.56%     
=========================================
  Files         118     118              
  Lines        5272    4595     -677     
=========================================
- Hits         1975    1604     -371     
+ Misses       3297    2991     -306

maciejkorsan commented Feb 12, 2018

Copy link
Copy Markdown
Member Author

@mkucharz changes applied

mkucharz approved these changes Feb 13, 2018
View reviewed changes

mkucharz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

maciejkorsan merged commit c029552 into master Feb 13, 2018
mkucharz deleted the docs/cookbook-socket-update branch February 15, 2018 21:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mkucharz mkucharz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL