FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: harden Prisma and Netlify scaffolds by tannerlinsley · Pull Request #492 · TanStack/cli · GitHub

/ cli Public

fix: harden Prisma and Netlify scaffolds - #492

Merged
tannerlinsley merged 1 commit into
mainfrom
taren/fix-partner-integration-followups
Jul 25, 2026
ConversationCommits (1)ChecksFiles changed
Merged

fix: harden Prisma and Netlify scaffolds#492
tannerlinsley merged 1 commit into
mainfrom
taren/fix-partner-integration-followups

Conversation

tannerlinsley commented Jul 25, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Summary

  • approve Prisma and Netlify native build dependencies for pnpm 10 and 11
  • make generated Prisma MySQL runtime and seed code honor DATABASE_URL
  • update the Prisma demo to current server-function and package-script APIs
  • add focused generator coverage and a patch changeset for @tanstack/create

Validation

  • full monorepo build
  • 101 CLI tests and 248 Create tests
  • 7 blocking end-to-end tests
  • fresh Prisma MySQL and React/Solid Netlify scaffold builds

Summary by CodeRabbit

  • Bug Fixes

    • Prisma-generated applications now consistently use the configured DATABASE_URL for MySQL and PostgreSQL.
    • Improved Prisma todo demo form handling, validation, reset behavior, and database-specific messaging.
    • Updated generated Prisma setup instructions to use the appropriate package-manager commands.

  • Improvements

    • Improved dependency build configuration for Prisma, SQLite, Netlify, and Cloudflare projects.
    • Generated projects now include only the dependencies required by the selected database and hosting options.

  • Tests

    • Added coverage for partner add-ons, database variants, environment-based configuration, and generated project setup.

coderabbitai Bot commented Jul 25, 2026 •
edited
Loading

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info ⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 26340be6-bff4-4888-b013-5477d1c829ab

📥 Commits

Reviewing files that changed from the base of the PR and between efd39a6 and 00ad1a1.

📒 Files selected for processing (11)
  • .changeset/honest-partner-paths.md
  • packages/create/src/frameworks/react/add-ons/prisma/assets/prisma/seed.ts.ejs
  • packages/create/src/frameworks/react/add-ons/prisma/assets/src/database-url.ts.ejs
  • packages/create/src/frameworks/react/add-ons/prisma/assets/src/db.ts.ejs
  • packages/create/src/frameworks/react/add-ons/prisma/assets/src/routes/demo/prisma.tsx.ejs
  • packages/create/src/frameworks/react/add-ons/prisma/package.json.ejs
  • packages/create/src/frameworks/react/hosts/netlify/package.json
  • packages/create/src/frameworks/react/project/base/pnpm-workspace.yaml.ejs
  • packages/create/src/frameworks/solid/hosts/netlify/package.json
  • packages/create/src/frameworks/solid/project/base/pnpm-workspace.yaml.ejs
  • packages/create/tests/partner-addons.test.ts
📝 Walkthrough

Walkthrough

The PR updates generated Prisma connection handling, pnpm build allowlists for Prisma and Netlify integrations, the Prisma demo’s server-function and script APIs, add-on option overrides, and partner add-on scaffolding tests.

Changes

Partner add-on scaffolding

Layer / File(s) Summary
Prisma database URL and adapter setup
packages/create/src/frameworks/react/add-ons/prisma/assets/src/database-url.ts.ejs, packages/create/src/frameworks/react/add-ons/prisma/assets/src/db.ts.ejs, packages/create/src/frameworks/react/add-ons/prisma/assets/prisma/seed.ts.ejs		 Non-sqlite Prisma adapters now use DATABASE_URL through getDatabaseUrl(), while sqlite generation remains file-based.
Partner dependency build configuration
packages/create/src/frameworks/react/add-ons/prisma/package.json.ejs, packages/create/src/frameworks/react/project/base/pnpm-workspace.yaml.ejs, packages/create/src/frameworks/react/hosts/netlify/package.json, packages/create/src/frameworks/solid/project/base/pnpm-workspace.yaml.ejs, packages/create/src/frameworks/solid/hosts/netlify/package.json		 Generated pnpm settings allow Prisma dependencies, SQLite dependencies, or sharp according to enabled add-ons and database selections.
Prisma demo commands and generator coverage
packages/create/src/frameworks/react/add-ons/prisma/assets/src/routes/demo/prisma.tsx.ejs, packages/create/tests/partner-addons.test.ts, .changeset/honest-partner-paths.md		 The demo uses updated validation, form handling, database labels, and package-manager scripts; generator option overrides and partner scaffolding assertions were added, with a patch changeset.
Estimated code review effort: 3 (Moderate) ~20 minutes
✨ Finishing Touches 📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch taren/fix-partner-integration-followups

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/create/tests/partner-addons.test.ts

Parsing error: "parserOptions.project" has been provided for @typescript-eslint/parser.
The file was not found in any of the provided project(s): packages/create/tests/partner-addons.test.ts

Comment @coderabbitai help to get the list of available commands.

tannerlinsley marked this pull request as ready for review July 25, 2026 04:03
tannerlinsley merged commit 4bb1384 into main Jul 25, 2026
6 of 7 checks passed
tannerlinsley deleted the taren/fix-partner-integration-followups branch July 25, 2026 04:03
github-actions Bot mentioned this pull request Jul 25, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

Back | FazBrowse Home | New Git URL