FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add option to enable/disable standard seo-tab and settings-tab by sbreiler · Pull Request #202 · TanStack/devtools · GitHub

/ devtools Public

Add option to enable/disable standard seo-tab and settings-tab #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sbreiler wants to merge 1 commit into
base: main
Choose a base branch
Could not load branches
Branch not found: {{ refName }}

Are you sure you want to change the base?

Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
from
+29 −6
Conversation 1 Commits 1 Checks 0 Files changed 4
Open

Add option to enable/disable standard seo-tab and settings-tab #202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .ts  (1) .tsx  (3) All 2 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
7 changes: 4 additions & 3 deletions packages/devtools/src/components/tab-content.tsx
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
import { createMemo } from 'solid-js'
import { useDevtoolsState } from '../context/use-devtools-context'
import { tabs } from '../tabs'
import { useDevtoolsSettings, useDevtoolsState } from '../context/use-devtools-context'
import { getTabs } from '../tabs'
import { useStyles } from '../styles/use-styles'
import type { JSX } from 'solid-js'

export const TabContent = () => {
const { state } = useDevtoolsState()
const { settings } = useDevtoolsSettings()
const styles = useStyles()
const component = createMemo<(() => JSX.Element) | null>(
() => tabs.find((t) => t.id === state().activeTab)?.component || null,
() => getTabs(settings()).find((t) => t.id === state().activeTab)?.component || null,
)

return <div class={styles().tabContent}>{component()?.()}</div>
Expand Down
7 changes: 4 additions & 3 deletions packages/devtools/src/components/tabs.tsx
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ import clsx from 'clsx'
import { For } from 'solid-js'
import { PiP, X } from '@tanstack/devtools-ui/icons'
import { useStyles } from '../styles/use-styles'
import { useDevtoolsState } from '../context/use-devtools-context'
import { useDevtoolsState, useDevtoolsSettings } from '../context/use-devtools-context'
import { useDrawContext } from '../context/draw-context'
import { tabs } from '../tabs'
import { getTabs } from '../tabs'
import { usePiPWindow } from '../context/pip-context'

interface TabsProps {
Expand All @@ -14,6 +14,7 @@ interface TabsProps {
export const Tabs = (props: TabsProps) => {
const styles = useStyles()
const { state, setState } = useDevtoolsState()
const { settings } = useDevtoolsSettings()
const pipWindow = usePiPWindow()
const handleDetachment = () => {
pipWindow().requestPipWindow(
Expand All @@ -24,7 +25,7 @@ export const Tabs = (props: TabsProps) => {

return (
<div class={styles().tabContainer}>
<For each={tabs}>
<For each={getTabs(settings())}>
{(tab) => (
<button
type="button"
Expand Down
12 changes: 12 additions & 0 deletions packages/devtools/src/context/devtools-store.ts
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,16 @@ export type DevtoolsStore = {
* @default TanStackLogo
*/
triggerImage: string
/**
* Whether the SEO tab is enabled
* @default true
*/
enableSeoTab: boolean
/**
* Whether the Settings tab is enabled
* @default true
*/
enableSettingsTab: boolean
}
state: {
activeTab: TabName
Expand All @@ -92,6 +102,8 @@ export const initialState: DevtoolsStore = {
? 'dark'
: 'light',
triggerImage: '',
enableSeoTab: true,
enableSettingsTab: true,
},
state: {
activeTab: 'plugins',
Expand Down
9 changes: 9 additions & 0 deletions packages/devtools/src/tabs/index.tsx
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { Cogs, List, PageSearch } from '@tanstack/devtools-ui/icons'
import { SettingsTab } from './settings-tab'
import { PluginsTab } from './plugins-tab'
import { SeoTab } from './seo-tab'
import type { DevtoolsStore } from '../context/devtools-store'

export const tabs = [
{
Expand All @@ -24,4 +25,12 @@ export const tabs = [
},
] as const

export const getTabs = (settings: DevtoolsStore['settings']) => {
return tabs.filter((t) => {
if (t.id === 'seo') return settings.enableSeoTab
if (t.id === 'settings') return settings.enableSettingsTab
return true
})
}

export type TabName = (typeof tabs)[number]['id']
Back | FazBrowse Home | New Git URL