refactor(event-client): simplify onAllPluginEvents implementation - #315
Open
nperez0111 wants to merge 3 commits into
Open
refactor(event-client): simplify onAllPluginEvents implementation#315nperez0111 wants to merge 3 commits into
nperez0111 wants to merge 3 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
🦋 Changeset detectedLatest commit: 5335723 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sorry, something went wrong.
nperez0111
force-pushed
the
simplify-plugin-events
branch
from
5401a62 to
1cd2e9f
Compare
January 13, 2026 11:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
This simplifies the onAllPluginEvents implementation, to just re-use the onAll implementation, since they are essentially duplicates, but the onAllPluginEvents implementation has an early exit when events are not from this plugin
✅ Checklist
🚀 Release Impact