fix: adjust use of solid-js in peerDeps and devDeps - #371
Open
birkskyum wants to merge 7 commits into
Open
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
🦋 Changeset detectedLatest commit: 1c5216c The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sorry, something went wrong.
Copy link
Copy Markdown
|
View your CI Pipeline Execution ↗ for commit 1c5216c
☁️ Nx Cloud last updated this comment at 2026-03-09 18:51:09 UTC |
Sorry, something went wrong.
Copy link
Copy Markdown
|
More templates
npm i https://pkg.pr.new/@tanstack/devtools@371
npm i https://pkg.pr.new/@tanstack/devtools-client@371
npm i https://pkg.pr.new/@tanstack/devtools-ui@371
npm i https://pkg.pr.new/@tanstack/devtools-utils@371
npm i https://pkg.pr.new/@tanstack/devtools-vite@371
npm i https://pkg.pr.new/@tanstack/devtools-event-bus@371
npm i https://pkg.pr.new/@tanstack/devtools-event-client@371
npm i https://pkg.pr.new/@tanstack/preact-devtools@371
npm i https://pkg.pr.new/@tanstack/react-devtools@371
npm i https://pkg.pr.new/@tanstack/solid-devtools@371
npm i https://pkg.pr.new/@tanstack/vue-devtools@371 commit: 639e746 |
Sorry, something went wrong.
birkskyum
marked this pull request as draft
March 6, 2026 21:23
birkskyum
marked this pull request as ready for review
March 6, 2026 21:31
Copy link
Copy Markdown
Collaborator
|
I'm not sure if this would impact the other libraries, did we actually confirm this does not cause issues? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@AlemTuzlak I've tried the repo examples react/start react/time-travel, and basic for few frameworks. E.g. react/basic example can run with the pre-releases form this PR "dependencies": {
"@tanstack/devtools-client": "https://pkg.pr.new/@tanstack/devtools-client@371",
"@tanstack/devtools-event-client": "https://pkg.pr.new/@tanstack/devtools-event-client@371",
"@tanstack/react-devtools": "https://pkg.pr.new/@tanstack/react-devtools@371",
"@tanstack/react-form": "^1.23.7",
"@tanstack/react-query": "^5.90.1",
"@tanstack/react-query-devtools": "^5.90.1",
"@tanstack/react-router": "^1.132.0",
"@tanstack/react-router-devtools": "^1.132.0",
"react": "^19.2.0",
"react-dom": "^19.2.0",
"zod": "^4.3.5"
},
"devDependencies": {
"@tanstack/devtools-ui": "https://pkg.pr.new/@tanstack/devtools-ui@371",
"@tanstack/devtools-vite": "https://pkg.pr.new/@tanstack/devtools-vite@371",
"@tanstack/react-form-devtools": "^0.1.7",
"@types/react": "^19.2.0",
"@types/react-dom": "^19.2.0",
"@vitejs/plugin-react": "^5.0.4",
"sonda": "0.9.0",
"vite": "^7.1.7",
"vite-plugin-inspect": "11.3.3"
},and that solid/basic can run wtih "dependencies": {
"@tanstack/solid-devtools": "https://pkg.pr.new/@tanstack/solid-devtools@371",
"@tanstack/solid-query": "^5.90.1",
"@tanstack/solid-query-devtools": "^5.90.1",
"@tanstack/solid-router": "^1.131.50",
"@tanstack/solid-router-devtools": "^1.131.50",
"solid-js": "^1.9.9"
},
"devDependencies": {
"@tanstack/devtools-vite": "https://pkg.pr.new/@tanstack/devtools-vite@371",
"vite": "^7.1.7",
"vite-plugin-inspect": "11.3.3",
"vite-plugin-solid": "^2.11.8"
},To do this, i remove the pnpm.overrides in the root package json, and set preferWorkspacePackages: false Is there something in particular that I can double check? |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adjust where solid-js v1 appear in peerDeps and devDeps, because the current setup gets in the way of e.g. router-devtools-core upgrading to solid v2. PR here:
With this pr the devtools become compatible with router devtools of both solid v1 and solid v2
🎯 Changes
✅ Checklist
🚀 Release Impact