Actionable comments posted: 1

packages/form-core/src/FormApi.ts (1)

1850-1858: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Extract duplicated array-version-bump loop into a shared helper.

The loop at lines 1851–1858 is identical to the one already in update() at lines 1786–1793. Extracting it into a private method (e.g., bumpArrayVersionsForAllFields()) would eliminate the duplication and ensure both call sites stay in sync.

♻️ Proposed refactor

+  /**
+   * `@private` Bump _arrayVersion for every mounted field whose value is an array.
+   */
+  private bumpArrayVersionsForAllFields = () => {
+    const helper = metaHelper(this)
+    for (const fieldKey of Object.keys(
+      this.fieldInfo,
+    ) as DeepKeys<TFormData>[]) {
+      if (Array.isArray(this.getFieldValue(fieldKey))) {
+        helper.bumpArrayVersion(fieldKey)
+      }
+    }
+  }
+
   reset = (values?: TFormData, opts?: { keepDefaultValues?: boolean }) => {
     // ... existing reset logic ...
 
-    const helper = metaHelper(this)
-    for (const fieldKey of Object.keys(
-      this.fieldInfo,
-    ) as DeepKeys<TFormData>[]) {
-      if (Array.isArray(this.getFieldValue(fieldKey))) {
-        helper.bumpArrayVersion(fieldKey)
-      }
-    }
+    this.bumpArrayVersionsForAllFields()
   }

Then apply the same replacement in update() at lines 1786–1793.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/form-core/src/FormApi.ts` around lines 1850 - 1858, Extract the
duplicated array-version-bump loop from update() and the shown flow into a
shared private method, such as bumpArrayVersionsForAllFields(). Have the helper
create or use metaHelper(this), iterate over fieldInfo keys, and call
bumpArrayVersion for array-valued fields; replace both existing loops with calls
to this method.

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/form-core/src/FormApi.ts`:
- Around line 2966-2969: Add a FormApi.spec.ts test covering resetField on an
array field, using the existing FormApi, FieldApi, and resetField test patterns.
Set an array value, call resetField, then assert the default array is restored
and the field meta _arrayVersion is bumped as expected.

---

Nitpick comments:
In `@packages/form-core/src/FormApi.ts`:
- Around line 1850-1858: Extract the duplicated array-version-bump loop from
update() and the shown flow into a shared private method, such as
bumpArrayVersionsForAllFields(). Have the helper create or use metaHelper(this),
iterate over fieldInfo keys, and call bumpArrayVersion for array-valued fields;
replace both existing loops with calls to this method.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b94af9cf-baaa-470c-9593-93e75079298b

Reviewing files that changed from the base of the PR and between 5d11281 and b59f247.

• .changeset/fix-array-reset-rerender.md
• packages/form-core/src/FormApi.ts
• packages/form-core/tests/FormApi.spec.ts
• packages/react-form/tests/useField.test.tsx

Went to check why bumping _arrayVersion specifically is what's needed here, and it's because react-form's useField deliberately subscribes to state.meta._arrayVersion instead of state.value for mode="array" fields, there's already a comment there referencing #1925 explaining it's an intentional optimization to avoid re-rendering on every child property change. That means for an array field, React genuinely does not know the array changed unless _arrayVersion itself changes, no matter what happened to the actual array reference or length. form.reset()/resetField() changing the array without touching that counter is exactly the kind of thing that selector is blind to, so the fix is targeting the right mechanism, not just papering over a symptom.

Checked the ordering in both call sites too. In reset(), the new loop runs after the baseStore.setState that actually commits the new values, so this.getFieldValue(fieldKey) inside the loop is reading the post-reset array, not stale state. Same story in resetField.

One minor thing, not a correctness issue: resetField isn't wrapped in batch(), so setting fieldMetaBase[field] to defaultFieldMeta (which resets _arrayVersion to 0) and then calling bumpArrayVersion right after are two separate store commits rather than one. Since the array value itself is already correct as of the first commit, this shouldn't produce wrong output, just possibly one extra render pass in cases where _arrayVersion wasn't already 0 going in. Worth a look if this file already batches similar multi-step meta+value updates elsewhere, but not something I'd block on.

Good that the React test renders through an actual mode="array" field and checks the DOM list length after reset, rather than asserting on internal state, since the whole point of the fix is what the UI shows, not just what the store holds.