Actionable comments posted: 1

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/form-core/tests/FormApi.spec.ts`:
- Around line 1974-1977: Update the regression comment in the FormApi test
around _handleSubmit to replace “Currently” with “Before this fix,” preserving
the description that the prior implementation bailed before validate('submit')
and documenting it as historical behavior.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 451a049e-47dc-4dc9-a1d9-487de253cc4d

Reviewing files that changed from the base of the PR and between 5d11281 and 7840e02.

• .changeset/form-level-validator-resubmit.md
• packages/form-core/src/FormApi.ts
• packages/form-core/tests/FormApi.spec.ts

Traced through validateAllFields and validate on main to make sure I understood what each one actually touches before judging the fix. validateAllFields('submit') calls every field's validate with skipFormValidation: true, so fieldErrors here is strictly field-level validator output, it never includes anything the form-level { fields } validator wrote. validate('submit') is the one that actually runs options.validators.onSubmit against the whole form and applies its fields map onto each field's error map. That separation is what makes the fix work.

The actual deadlock in #2248 makes sense once you see that isFieldsValid is a stale aggregate: after the first submit, the form-level validator writes Required into fieldMeta.name.errorMap.onSubmit and fieldMeta.other. On the second submit, there are no field-level validators to touch those entries, so isFieldsValid is still reading last submit's form-level output at the point the old code checked it, before validate('submit') ever got a chance to re-run and overwrite it. Gating the early-return on this.state.isFieldsValid was gating on data the form-level validator itself was supposed to refresh.

Switching the condition to fieldErrors.length === 0 fixes it because that's always this submit's fresh result, not a carried-over flag. And behaviorally nothing changes for the case that matters, when a field-level validator does fail, fieldErrors.length > 0 skips the form-level validator exactly like the old isFieldsValid gate did, since a field-level failure alone was already enough to fail isFieldsValid before. The only path that changes is the one that was actually broken, field-level clean but form-level state stale, and now the form-level validator gets to run and clear its own mess before the gate checks anything.

I also want to flag that the second await this.validate('submit') further down wasn't duplicated, it was moved, so the form-level validator still runs at most once per submit attempt in the passing path. That's an easy thing to get subtly wrong when relocating a call like this, and it's clean here.

Test is solid, it reproduces the exact regression path (submit empty, see fields get flagged by the form-level validator, fill the fields, submit again) and asserts both that the stale errors clear and that onSubmit actually fires, which is the part that would have silently failed forever under the old code without ever throwing.