| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 8087fcbe-ade6-42f8-b190-ad0704c60128 📥 CommitsReviewing files that changed from the base of the PR and between 86bb8a6 and cc8615f. 📒 Files selected for processing (4)
📝 Walkthrough WalkthroughTests tighten Solid Query cache and mutation assertions by validating stored data values, cache isolation, explicit undefined results, and filtered mutation output. ChangesSolid Query test assertions
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: sukvvon 🚥 Pre-merge checks | ✅ 5 ✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. ❤️ ShareComment @coderabbitai help to get the list of available commands. |
Sorry, something went wrong.
|
View your CI Pipeline Execution ↗ for commit cc8615f
☁️ Nx Cloud last updated this comment at 2026-07-26 05:26:17 UTC |
Sorry, something went wrong.
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
🎯 Changes
Continues the recent test-quality series (e.g. #11057, #11093) by converting the toBeTruthy() / toBeFalsy() / toBeDefined() assertions in solid-query tests to exact assertions:
One toBeDefined() is intentionally left in place: in useQuery → "should refetch query when queryClient changes", tightening the queryClient2 cache check to ?.state.data fails. After setClient(queryClient2), the second queryFn call actually lands in queryClient1's cache (its dataUpdateCount goes to 2) while the entry in queryClient2's cache stays status: 'pending' / fetchStatus: 'idle' and never fetches. This looks like an observer re-subscription ordering issue in useBaseQuery (in the on(client, ...) computed, createClientSubscriber() is called before setObserver(newObserver), so the subscription attaches to the old observer). I'd rather report and fix that separately than encode the current behavior into an exact assertion here.
After this, grep -rE 'toBeTruthy\(\)|toBeFalsy\(\)|toBeDefined\(\)' packages/solid-query/src only matches the site described above.
✅ Checklist
Local verification detail: vitest run on the four edited files — 162 tests passed, no type errors; test:eslint and prettier clean; full-suite failure set identical to main in the same environment.
🚀 Release Impact
Summary by CodeRabbit