FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

ref: remove unused experimental_beforeQuery and experimental_afterQuery by TkDodo · Pull Request #11233 · TanStack/query · GitHub

/ query Public

ref: remove unused experimental_beforeQuery and experimental_afterQuery - #11233

Merged
TkDodo merged 1 commit into
mainfrom
tkdodo/ref/remove-before-after-query
Aug 19, 2026
ConversationCommits (1)ChecksFiles changed
Merged

ref: remove unused experimental_beforeQuery and experimental_afterQuery#11233
TkDodo merged 1 commit into
mainfrom
tkdodo/ref/remove-before-after-query

Conversation

TkDodo commented Aug 19, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Breaking Changes
    • Removed the unused experimental beforeQuery and afterQuery hooks from React Query and Preact Query.
  • Release
    • Published patch-level updates for the React Query and Preact Query packages.

nx-cloud Bot commented Aug 19, 2026 •
edited
Loading

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 8aeaa35

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 5m 19s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 12s View ↗

☁️ Nx Cloud last updated this comment at 2026-08-19 18:32:59 UTC

coderabbitai Bot commented Aug 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info ⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 5e9281d4-d2d9-4177-8fe6-e227b654a339

📥 Commits

Reviewing files that changed from the base of the PR and between b8e3559 and 8aeaa35.

📒 Files selected for processing (3)
  • .changeset/true-cobras-wait.md
  • packages/preact-query/src/useBaseQuery.ts
  • packages/react-query/src/useBaseQuery.ts
💤 Files with no reviewable changes (2)
  • packages/react-query/src/useBaseQuery.ts
  • packages/preact-query/src/useBaseQuery.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

Walkthrough

The Preact and React useBaseQuery implementations no longer invoke the experimental query lifecycle callbacks. A changeset declares patch releases for both packages.

Changes

Experimental query callback removal

Layer / File(s) Summary
Remove callback invocations
packages/preact-query/src/useBaseQuery.ts, packages/react-query/src/useBaseQuery.ts, .changeset/true-cobras-wait.md		 Both query hooks no longer invoke _experimental_beforeQuery or _experimental_afterQuery. The changeset records patch releases for both packages.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 8aeaa

This localized cleanup removes unused experimental query hooks without any supplied evidence of a current merge-blocking issue; it is merge-ready after normal checks and review.

Possibly related PRs

Suggested labels: package: react-query

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning No pull request description was provided, so the required changes, checklist, and release impact information are missing. Add the required Changes, Checklist, and Release Impact sections, and document the motivation, testing status, and changeset.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely identifies the removal of the unused experimental callbacks.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch tkdodo/ref/remove-before-after-query

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

github-actions Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

9 package(s) bumped directly, 16 bumped as dependents.

🟨 Minor bumps

Package Version Reason
@tanstack/angular-query-experimental 5.101.4 → 5.102.0 Changeset
@tanstack/eslint-plugin-query 5.101.4 → 5.102.0 Changeset
@tanstack/preact-query 5.101.4 → 5.102.0 Changeset
@tanstack/query-core 5.101.4 → 5.102.0 Changeset
@tanstack/react-query 5.101.4 → 5.102.0 Changeset
@tanstack/solid-query 5.101.4 → 5.102.0 Changeset
@tanstack/vue-query 5.101.4 → 5.102.0 Changeset
@tanstack/angular-query-persist-client 5.101.4 → 5.102.0 Dependent
@tanstack/preact-query-devtools 5.101.4 → 5.102.0 Dependent
@tanstack/preact-query-persist-client 5.101.4 → 5.102.0 Dependent
@tanstack/query-async-storage-persister 5.101.4 → 5.102.0 Dependent
@tanstack/query-broadcast-client-experimental 5.101.4 → 5.102.0 Dependent
@tanstack/query-devtools 5.101.4 → 5.102.0 Dependent
@tanstack/query-persist-client-core 5.101.4 → 5.102.0 Dependent
@tanstack/query-sync-storage-persister 5.101.4 → 5.102.0 Dependent
@tanstack/react-query-devtools 5.101.4 → 5.102.0 Dependent
@tanstack/react-query-next-experimental 5.101.4 → 5.102.0 Dependent
@tanstack/react-query-persist-client 5.101.4 → 5.102.0 Dependent
@tanstack/solid-query-devtools 5.101.4 → 5.102.0 Dependent
@tanstack/solid-query-persist-client 5.101.4 → 5.102.0 Dependent

🟩 Patch bumps

Package Version Reason
@tanstack/lit-query 0.2.11 → 0.2.12 Changeset
@tanstack/svelte-query 6.1.38 → 6.1.39 Changeset
@tanstack/svelte-query-devtools 6.1.38 → 6.1.39 Dependent
@tanstack/svelte-query-persist-client 6.1.38 → 6.1.39 Dependent
@tanstack/vue-query-devtools 6.1.38 → 6.1.39 Dependent

pkg-pr-new Bot commented Aug 19, 2026

Copy link
Copy Markdown
More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@11233

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@11233

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@11233

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@11233

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@11233

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@11233

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@11233

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@11233

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@11233

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@11233

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@11233

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@11233

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@11233

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@11233

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@11233

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@11233

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@11233

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@11233

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@11233

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@11233

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@11233

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@11233

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@11233

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@11233

commit: 8aeaa35

github-actions Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
react full 12.26 KB (-0.23% 🔽)
react minimal 9.21 KB (-0.29% 🔽)

TkDodo merged commit b866a95 into main Aug 19, 2026
9 checks passed
TkDodo deleted the tkdodo/ref/remove-before-after-query branch August 19, 2026 18:34
github-actions Bot mentioned this pull request Aug 19, 2026
Open
coderabbitai Bot mentioned this pull request Aug 19, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

Back | FazBrowse Home | New Git URL