FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add i18n toggle button (en & zh-hans) by xiaoyu2er · Pull Request #400 · TanStack/tanstack.com · GitHub

Add i18n toggle button (en & zh-hans) - #400

Closed
xiaoyu2er wants to merge 2 commits into
TanStack:mainfrom
TanStack-dev:main
Closed

Add i18n toggle button (en & zh-hans)#400
xiaoyu2er wants to merge 2 commits into
TanStack:mainfrom
TanStack-dev:main

Conversation

Copy link
Copy Markdown

In this PR, we add translate redirect ability.

  • add a translate button at the logo sections (app/routes/_libraries/route.tsx &app/components/DocsLayout.tsx)
  • add i18n meta links

The current translate button supports two languages: english (https://tanstack.com/) & zh-Hans (https://zh-hans.tanstack.dev/)

Here are some screenshots:

netlify Bot commented May 7, 2025
edited
Loading

Copy link
Copy Markdown

👷 Deploy request for tanstack pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit c1f983e

Comment thread package.json
"@sentry/react": "^8.35.0",
"@sentry/vite-plugin": "^2.22.6",
"@tailwindcss/typography": "^0.5.13",
"@tanstack-dev/components": "^1.4.0",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I don't think it would be a good idea to install a 3rd party dependency like this. This component should just live in this codebase.

Copy link
Copy Markdown
Member

How do the translations work? Where do they come from? Where do they live?

Copy link
Copy Markdown
Member

I see that this PR is actually suggesting to redirect to a translated mirror on tanstack.com. While the effort is appreciated, and we do want to offer the tanstack docs in other languages, I think we need to figure out a way to do an AI translate in our build pipelines in a way in which is not too expensive. Otherwise, our ever evolving docs will get out of date in the mirrors. I almost think that it's more important for docs to be up to date than translated, as there are already browser tools that can translate our real most up to date docs, at least.

xiaoyu2er closed this Jun 21, 2025

leesb971204 commented Jul 3, 2025
edited
Loading

Copy link
Copy Markdown

@KevinVandy

Hi, I’m a developer from Korea currently using TanStack Query and TanStack Router.
While looking for ways to help provide official TanStack documentation in other languages, I came across this PR.

In Korea, many developers are already using TanStack’s excellent libraries, and there are Korean-translated versions of the documentation created to support learning through the official docs. (query, router)

I’m very interested in contributing to this effort and wanted to ask if you have any plans to officially support translations of TanStack’s documentation into multiple languages.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL