FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[refactor] replace JSX factory with JSX runtime by Copilot · Pull Request #5 · TechQuery/CommanderJSX · GitHub

/ CommanderJSX Public

[refactor] replace JSX factory with JSX runtime - #5

Merged
TechQuery merged 5 commits into
JSX-import-sourcefrom
copilot/sub-pr-4
Oct 29, 2025
ConversationCommits (5)ChecksFiles changed
Merged

[refactor] replace JSX factory with JSX runtime#5
TechQuery merged 5 commits into
JSX-import-sourcefrom
copilot/sub-pr-4

Conversation

Copilot AI commented Oct 29, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Create jsx-runtime.ts file with jsx, jsxs, jsxDEV, and Fragment exports
  • Update tsconfig.json to use react-jsx and jsxImportSource
  • Update test/tsconfig.json to use react-jsx and jsxImportSource
  • Remove createCommand export and JSX global type declarations from creator.ts
  • Update tests to use new JSX runtime (remove createCommand imports if needed)
  • Build and test to ensure everything works
  • Add parcel script to copy jsx-runtime files to root directory
  • Update README documentation
  • Add compiled jsx-runtime files to .gitignore (generated during build/publish)

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI mentioned this pull request Oct 29, 2025
Merged
Copilot AI and others added 3 commits October 29, 2025 18:57
Refactor from JSX factory to JSX runtime
5b94a18 
Co-authored-by: TechQuery <19969570+TechQuery@users.noreply.github.com>
Update README to reflect JSX runtime usage
a475919 
Co-authored-by: TechQuery <19969570+TechQuery@users.noreply.github.com>
Changes before error encountered
212d5a5 
Co-authored-by: TechQuery <19969570+TechQuery@users.noreply.github.com>
Copilot AI requested a review from TechQuery October 29, 2025 18:59
TechQuery requested changes Oct 29, 2025
View reviewed changes

TechQuery left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@copilot TS 编译后的文件不要传上来，要忽略掉。

Ignore compiled jsx-runtime files from git
03a51a9 
Co-authored-by: TechQuery <19969570+TechQuery@users.noreply.github.com>

Copilot AI commented Oct 29, 2025

Copy link
Copy Markdown
Contributor Author

@copilot TS 编译后的文件不要传上来，要忽略掉。

Done in commit 03a51a9. Added the compiled jsx-runtime files to .gitignore:

  • jsx-runtime.js
  • jsx-runtime.d.ts
  • jsx-dev-runtime.js
  • jsx-dev-runtime.d.ts

These files are now generated during the build process and will be included in npm packages via the prepublishOnly script, but won't be committed to git.

Copilot AI requested a review from TechQuery October 29, 2025 19:08
TechQuery marked this pull request as ready for review October 29, 2025 19:21
TechQuery added the enhancement New feature or request label Oct 29, 2025
TechQuery changed the title [WIP] Refactor JSX factory to use JSX import source [refactor] replace JSX factory with JSX runtime Oct 29, 2025
TechQuery merged commit 1336a7e into JSX-import-source Oct 29, 2025
TechQuery deleted the copilot/sub-pr-4 branch October 29, 2025 19:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
TechQuery TechQuery approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

TechQuery

Copilot code review Copilot

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL