fix: fix global @explain not effective - #860
Merged
TommyLemon merged 1 commit intoJun 11, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
TommyLemon
approved these changes
Jun 11, 2026
Copy link
Copy Markdown
Collaborator
|
@Zhengcy05 Thank you for your contribution~ However, this PR is too tiny to run the test cases. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
This PR fixes the global @Explain propagation logic in AbstractObjectParser.
Previously, root-level @Explain was parsed correctly as a global option, but when the framework applied global defaults to table objects, it checked globalSchema instead of globalExplain before injecting KEY_EXPLAIN. As a result, global @Explain only worked when global @Schema was also present.
This change updates the condition to check the global explain flag itself, so root-level @Explain now works as documented without depending on @Schema.
Ⅱ. Does this pull request fix one issue?
fixes #851
Ⅲ. Why don't you add test cases (unit test/integration test)?
This repository currently does not have an existing test structure under APIJSONORM/src/test, and this PR keeps the change minimal and focused to a one-line bug fix.
The change was verified by compilation and by tracing the request parsing path against the reported issue scenario.
Ⅳ. Describe how to verify it
Run:
Ⅴ. Special notes for reviews
This is a minimal fix that only corrects the propagation condition for global @Explain.
It does not change:
subquery behavior
object-level @Explain behavior
any SQL generation logic beyond the global default injection path