feat: Transposition cipher - #375
Merged
siriak merged 4 commits intoOct 19, 2021
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
i-redbyte
requested review from
raklaptudirm,
siriak and
tjgurwara99
as code owners
October 7, 2021 23:44
raklaptudirm
previously approved these changes
Oct 8, 2021
tjgurwara99
requested changes
Oct 8, 2021
tjgurwara99
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Your way of writing Go has improved significantly (from the few PRs that you have raised which I have reviewed). Glad to see that this repo is making an impact. As such, I'm writing extensive suggestions from my perspective so that you can learn as much as you can from these 😄 - hopefully these suggestions are of use to you and teach you something.
Sorry, something went wrong.
Comment thread
cipher/transposition/transposition.go
Outdated
Comment thread
cipher/transposition/transposition.go
Outdated
Comment thread
cipher/transposition/transposition.go
Outdated
Comment thread
cipher/transposition/transposition.go
Outdated
Comment thread
cipher/transposition/transposition_test.go
Comment thread
cipher/transposition/transposition.go
Outdated
Comment thread
cipher/transposition/transposition.go
Outdated
Comment thread
cipher/transposition/transposition_test.go
Outdated
Comment thread
cipher/transposition/transposition_test.go
Outdated
Comment thread
cipher/transposition/transposition_test.go
tjgurwara99
reviewed
Oct 9, 2021
Comment thread
cipher/transposition/transposition_test.go
tjgurwara99
approved these changes
Oct 16, 2021
Copy link
Copy Markdown
Member
Author
|
@siriak @raklaptudirm What about a pull request? |
Sorry, something went wrong.
siriak
approved these changes
Oct 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation Transposition cipher