Refactorized ClosestPair.java in order to be compliant with java sun rules - #502
Merged
varunu28 merged 1 commit intoSep 9, 2018
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@MarisaAfuera You can add the algorithm to the master right now but we are adding tests to Development branch in order to avoid confusion. So you can do either of the two below mentioned things:
Avoid creating another class for location. You can put it up in same file |
Sorry, something went wrong.
varunu28
suggested changes
Sep 6, 2018
varunu28
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
- You have to remove the test if you want to push this to master. Else you can follow the guidelines mentioned in Development branch and make a PR for that branch
- Move the location class inside ClosestPair as we don't need a separate file for Location
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Yes varun. I was busy. Next weekend I will fix It.
El jue., 6 sept. 2018 22:21, Varun Upadhyay <notifications@github.com>
escribió:
… ***@***.**** requested changes on this pull request.
- You have to remove the test if you want to push this to master. Else
you can follow the guidelines mentioned in Development branch and make a PR
for that branch
- Move the location class inside ClosestPair as we don't need a
separate file for Location
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#502 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ASac7FyEzBIfijE4g0btptnzcNdKh5tWks5uYZHvgaJpZM4WT69b>
.
|
Sorry, something went wrong.
…rules commit divideconquer\ClosesPair.java Refactorized ClosestPair.java. Finding nearest cartesian points. Refactorized ClosestPair.java. Finding nearest cartesian points.
Copy link
Copy Markdown
Contributor
Author
|
I think I've made the requesting changes. Now in files changed tab only is showed ClosestPair.java. No test neither Location class are available. Also I squash the commits with git rebase. @varunu28 Is everything right? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Hi,
@varun I've made the requested changes. I everything right?
El jue., 6 sept. 2018 a las 23:21, Varun Upadhyay (<notifications@github.com>)
escribió:
… ***@***.**** requested changes on this pull request.
- You have to remove the test if you want to push this to master. Else
you can follow the guidelines mentioned in Development branch and make a PR
for that branch
- Move the location class inside ClosestPair as we don't need a
separate file for Location
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#502 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ASac7FyEzBIfijE4g0btptnzcNdKh5tWks5uYZHvgaJpZM4WT69b>
.
|
Sorry, something went wrong.
varunu28
approved these changes
Sep 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactorized ClosestPair.java: adding commets, eliminating unuseful parameters, reorganizing code lines to be less than 80 characteres, each variable declaration in one line.
I've deleted txt file to provide input data.
I've created a unit test class. To complete the tests I've created a auxiliary type Location.