FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fixes #7350: Binary Search Reliability Improvement by surajdm123 · Pull Request #7351 · TheAlgorithms/Java · GitHub

  1. TheAlgorithms
  2. Java

Repository navigation

Fixes #7350: Binary Search Reliability Improvement - #7351

Merged
DenizAltunkapan merged 2 commits into
TheAlgorithms:masterfrom
surajdm123:7350-binary-search-reliability-improvement
Mar 30, 2026
ConversationCommits (2)ChecksFiles changed
Merged

Fixes #7350: Binary Search Reliability Improvement#7351
DenizAltunkapan merged 2 commits into
TheAlgorithms:masterfrom
surajdm123:7350-binary-search-reliability-improvement

Conversation

surajdm123 commented Mar 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Checklist

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new algorithms include a corresponding test class that validates their functionality.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

Summary

Fixes #7350 by adding missing test cases to improve the reliability of the Binary Search Algorithm.

Changes

  • Added test for null array input to ensure method safely returns -1.
  • Added test for duplicate elements to validate correct behavior when multiple matches exist.
  • Added test for arrays with all identical elements.
  • Added test for negative numbers to verify correct comparison handling.
  • Added tests for keys outside array bounds:
  • Key smaller than the smallest element
  • Key larger than the largest element
  • Added test for generic type support using String arrays.
  • Added test for unsorted array input to ensure method does not crash (behavior undefined but handled safely).

Test Plan

Fixes #7350

codecov-commenter commented Mar 29, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.48%. Comparing base (bdbbece) to head (4c1e80e).

Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #7351      +/-   ##
============================================
+ Coverage     79.47%   79.48%   +0.01%     
- Complexity     7092     7094       +2     
============================================
  Files           791      791              
  Lines         23202    23202              
  Branches       4565     4565              
============================================
+ Hits          18440    18443       +3     
  Misses         4024     4024              
+ Partials        738      735       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

surajdm123 marked this pull request as ready for review March 29, 2026 08:26
surajdm123 mentioned this pull request Mar 29, 2026
Closed
DenizAltunkapan enabled auto-merge (squash) March 30, 2026 17:53
DenizAltunkapan merged commit d2744b5 into TheAlgorithms:master Mar 30, 2026
7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

DenizAltunkapan DenizAltunkapan approved these changes
yanglbme Awaiting requested review from yanglbme yanglbme is a code owner
alxkm Awaiting requested review from alxkm alxkm is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add test cases for edge conditions in BinarySearch

3 participants

Back | FazBrowse Home | New Git URL