FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

algorithm: SegmentTree by changicho · Pull Request #1178 · TheAlgorithms/JavaScript · GitHub

/ JavaScript Public

algorithm: SegmentTree - #1178

Merged
raklaptudirm merged 6 commits into
TheAlgorithms:masterfrom
changicho:feature/segment-tree
Oct 20, 2022
ConversationCommits (6)ChecksFiles changed
Merged

algorithm: SegmentTree#1178
raklaptudirm merged 6 commits into
TheAlgorithms:masterfrom
changicho:feature/segment-tree

Conversation

changicho commented Oct 13, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

 know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

appgurueu reviewed Oct 13, 2022
View reviewed changes

appgurueu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Elegant & clever implementation. Can you try to add more comments?

changicho commented Oct 14, 2022

Copy link
Copy Markdown
Contributor Author

Elegant & clever implementation. Can you try to add more comments?

Sure! I add comments in new commit. Please check. Thanks.

appgurueu commented Oct 14, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

I was thinking of comments on the implementation details (e.g. how you store the binary tree in a list (same trick as heaps often use), how to calc. the parent pos. from a child pos. and vice versa).

changicho commented Oct 14, 2022

Copy link
Copy Markdown
Contributor Author

I was thinking of comments on the implementation details (e.g. how you store the binary tree in a list (same trick as heaps often use), how to calc. the parent pos. from a child pos. and vice versa).

I add comments on the implementation details in new commit!

appgurueu reviewed Oct 14, 2022
View reviewed changes
Comment thread Data-Structures/Tree/SegmentTree.js Outdated
appgurueu previously approved these changes Oct 14, 2022
View reviewed changes
feat: Remove useless comment
2c3077a 
it duplicated by next line. so it is not necessary
changicho changed the title Create SegmentTree algorithm: SegmentTree Oct 15, 2022

changicho commented Oct 18, 2022

Copy link
Copy Markdown
Contributor Author

@raklaptudirm Could you review this PR? 🙏

raklaptudirm merged commit 5867186 into TheAlgorithms:master Oct 20, 2022
changicho deleted the feature/segment-tree branch October 21, 2022 08:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

appgurueu appgurueu approved these changes
raklaptudirm raklaptudirm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL