FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

algorithm class: circle by Japoncio3k · Pull Request #1252 · TheAlgorithms/JavaScript · GitHub

/ JavaScript Public

algorithm class: circle - #1252

Merged
raklaptudirm merged 4 commits into
TheAlgorithms:masterfrom
Japoncio3k:circlePerimeter
Oct 31, 2022
ConversationCommits (4)ChecksFiles changed
Merged

algorithm class: circle#1252
raklaptudirm merged 4 commits into
TheAlgorithms:masterfrom
Japoncio3k:circlePerimeter

Conversation

Japoncio3k commented Oct 30, 2022 •
edited by gitpod-io Bot
Loading

Copy link
Copy Markdown
Contributor

 know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

appgurueu requested changes Oct 30, 2022
View reviewed changes

appgurueu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please move this in a Circle class together with the area of a circle.

Japoncio3k commented Oct 30, 2022

Copy link
Copy Markdown
Contributor Author

should i do both the area and the perimeter in one commit?

appgurueu commented Oct 30, 2022

Copy link
Copy Markdown
Collaborator

Yes

Japoncio3k requested a review from appgurueu October 30, 2022 13:47
appgurueu reviewed Oct 30, 2022
View reviewed changes
Comment thread Geometry/Test/Circle.test.js Outdated
Japoncio3k requested a review from appgurueu October 30, 2022 14:16
raklaptudirm changed the title Added circle perimeter algorithm class: circle Oct 31, 2022
raklaptudirm merged commit 7256e53 into TheAlgorithms:master Oct 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

appgurueu appgurueu approved these changes
raklaptudirm raklaptudirm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL