perf: optimize factor calculation - #1910
Open
oozan wants to merge 2 commits into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## master #1910 +/- ##
==========================================
+ Coverage 85.91% 85.93% +0.01%
==========================================
Files 379 379
Lines 19778 19798 +20
Branches 3016 3021 +5
==========================================
+ Hits 16993 17013 +20
Misses 2785 2785 ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
At least 2 approving reviews are required to merge this pull request.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Optimizes factor calculation by examining divisor pairs only up to the square root of the input.
This reduces the running time from O(n) to O(sqrt(n)) and avoids allocating an intermediate array containing every integer up to the input. Results remain sorted, and perfect-square roots are not duplicated.
Testing
AI assistance was used to prepare this focused change. I reviewed and validated the implementation.