FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: unbiased Fisher-Yates in bogoSort; do not mutate RGB input by zeeshanzzz788 · Pull Request #1912 · TheAlgorithms/JavaScript · GitHub

/ JavaScript Public

fix: unbiased Fisher-Yates in bogoSort; do not mutate RGB input #1912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zeeshanzzz788 wants to merge 1 commit into
base: master
Choose a base branch
Could not load branches
Branch not found: {{ refName }}

Are you sure you want to change the base?

Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
from
Conversation 1 Commits 1 Checks 3 Files changed
Open

fix: unbiased Fisher-Yates in bogoSort; do not mutate RGB input #1912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .js  (2) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
3 changes: 2 additions & 1 deletion Conversions/RgbHslConversion.js
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ const rgbToHsl = (colorRgb) => {
throw new Error('Input is not a valid RGB color.')
}

let colorHsl = colorRgb
// Work on a copy so the caller's RGB array is not mutated
let colorHsl = colorRgb.slice()

let red = Math.round(colorRgb[0])
let green = Math.round(colorRgb[1])
Expand Down
11 changes: 5 additions & 6 deletions Sorts/BogoSort.js
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,13 @@ export function isSorted(array) {
}

/**
* Shuffles the given array randomly in place.
* Unbiased Fisher–Yates shuffle of the given array in place.
* Each permutation is equally likely.
*/
function shuffle(array) {
for (let i = array.length - 1; i; i--) {
const m = Math.floor(Math.random() * i)
const n = array[i - 1]
array[i - 1] = array[m]
array[m] = n
for (let i = array.length - 1; i > 0; i--) {
const j = Math.floor(Math.random() * (i + 1))
;[array[i], array[j]] = [array[j], array[i]]
}
}

Expand Down
Loading
Back | FazBrowse Home | New Git URL