FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

optamization, documantation, change return Array[bool] => Array[primes only], Add test case by Yatin-kathuria · Pull Request #841 · TheAlgorithms/JavaScript · GitHub

/ JavaScript Public

optamization, documantation, change return Array[bool] => Array[primes only], Add test case - #841

Merged
raklaptudirm merged 1 commit into
TheAlgorithms:masterfrom
Yatin-kathuria:sieveOfEratosthenes
Nov 20, 2021
ConversationCommits (1)ChecksFiles changed
Merged

optamization, documantation, change return Array[bool] => Array[primes only], Add test case #841
raklaptudirm merged 1 commit into
TheAlgorithms:masterfrom
Yatin-kathuria:sieveOfEratosthenes

Conversation

Yatin-kathuria commented Nov 20, 2021

Copy link
Copy Markdown
Contributor

Welcome to JavaScript community

 know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

raklaptudirm added feature Adds a new feature Reviewed labels Nov 20, 2021
raklaptudirm merged commit 02a4cee into TheAlgorithms:master Nov 20, 2021
Yatin-kathuria deleted the sieveOfEratosthenes branch November 22, 2021 16:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

raklaptudirm raklaptudirm approved these changes

Assignees

No one assigned

Labels

feature Adds a new feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL