Update fibonacci-solution.js - #370
Merged
01zulfi merged 3 commits intoJul 7, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Better O(n) time
01zulfi
requested changes
Jul 5, 2023
01zulfi
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I like the proposed solution. IMO it's easier to understand. Just have one small nit below
Sorry, something went wrong.
Comment thread
10_fibonacci/solution/fibonacci-solution.js
Outdated
01zulfi
requested changes
Jul 6, 2023
Comment thread
10_fibonacci/solution/fibonacci-solution.js
Outdated
Comment on lines
+8
to
+13
| // For clarification: curr stands for current. This is standard syntax | ||
|
|
||
| for (let i = 2; i <= count; i++) { | ||
| let curr = firstPrev + secondPrev; | ||
| secondPrev = firstPrev; | ||
| firstPrev = curr; |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Just one more small change please. Can we go for current instead of curr and remove the comment? This exercise is fairly early in the curriculum and I want the variable names to be as clear as possible for the learners. Thanks!
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Done
Sorry, something went wrong.
01zulfi
approved these changes
Jul 7, 2023
01zulfi
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM 🚀
Sorry, something went wrong.
Oussama5379
added a commit
to Oussama5379/javascript-exercises
that referenced
this pull request
Feb 1, 2025
Update fibonacci-solution.js
painooo
pushed a commit
to painooo/javascript-exercises
that referenced
this pull request
Dec 29, 2025
Update fibonacci-solution.js
Paodpdro
pushed a commit
to Paodpdro/javascript-exercises
that referenced
this pull request
May 19, 2026
Update fibonacci-solution.js
FredTheJanitor
pushed a commit
to FredTheJanitor/javascript-exercises
that referenced
this pull request
May 29, 2026
Update fibonacci-solution.js
FredTheJanitor
pushed a commit
to FredTheJanitor/javascript-exercises
that referenced
this pull request
May 29, 2026
Update fibonacci-solution.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More optimized solution with O(1) memory usage