FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Better conda by abergeron · Pull Request #512 · Theano/libgpuarray · GitHub

/ libgpuarray Public

Better conda - #512

Merged
nouiz merged 20 commits into
Theano:masterfrom
abergeron:better_conda
Sep 1, 2017
ConversationCommits (20)ChecksFiles changed
Merged

Better conda#512
nouiz merged 20 commits into
Theano:masterfrom
abergeron:better_conda

Conversation

abergeron commented Sep 1, 2017

Copy link
Copy Markdown
Member

No description provided.

abergeron force-pushed the better_conda branch 2 times, most recently from 73673e9 to af33c30 Compare September 1, 2017 18:49
abergeron force-pushed the better_conda branch 2 times, most recently from 77a779c to 2884bde Compare September 1, 2017 19:17

abergeron commented Sep 1, 2017 •
edited
Loading

Copy link
Copy Markdown
Member Author

This is where I'll stop for now.

I changed the appveyor build to make conda packages for python 2.7 and 3.5 of libgpuarray and pygpu. They are kept as "build artifacts" on the appveyor build page.

There is no automatic upload yet, but it could be added in a subsequent PR.

Also kept for later: automatic package builds for mac and linux.

nouiz approved these changes Sep 1, 2017
View reviewed changes
Comment thread conda/pygpu/meta.yaml
- python
- cython >=0.25
- numpy x.x
- numpy 1.11

nouiz Sep 1, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Does it mean it will only support numpy 1.11? Why not bump that to 1.13 to support the more recent version?

abergeron Sep 1, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

No, it was discovered that numpy is forward-compatible. So it should work with numpy 1.12 and 1.13 too (and 1.14 whenever it comes out).

nouiz merged commit 8f21ba2 into Theano:master Sep 1, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

nouiz nouiz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL