FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

pygpu/tests: Skip tests that require CUDA context if the context is not CUDA by jvesely · Pull Request #571 · Theano/libgpuarray · GitHub

/ libgpuarray Public

pygpu/tests: Skip tests that require CUDA context if the context is not CUDA - #571

Merged
abergeron merged 1 commit into
Theano:masterfrom
jvesely:cuda_test
Apr 23, 2018
ConversationCommits (1)ChecksFiles changed
Merged

pygpu/tests: Skip tests that require CUDA context if the context is not CUDA#571
abergeron merged 1 commit into
Theano:masterfrom
jvesely:cuda_test

Conversation

jvesely commented Apr 5, 2018

Copy link
Copy Markdown
Contributor

Fixes #491
Signed-off-by: Jan Vesely jan.vesely@rutgers.edu

jvesely commented Apr 17, 2018

Copy link
Copy Markdown
Contributor Author

@nouiz, are you interested in bug fixes?

abergeron commented Apr 18, 2018

Copy link
Copy Markdown
Member

Yes we are, however I would fix this differently. The only part of those tests that require a cuda context is the .gpudata access. You could make that part conditional on the context kind and the rest should pass.

pygpu/tests: Do not compare gpudata if the context is not CUDA
0c25f2c 
Fixes Theano#491
v2: Do not skip the entire test
Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>

nouiz commented Apr 23, 2018

Copy link
Copy Markdown
Member

@abergeron this PR was updated. Can you review it again?
@jvesely when you update a commit and force push, this do not send a notification. So if you can make comment, it will make us see the change faster.

jvesely commented Apr 23, 2018

Copy link
Copy Markdown
Contributor Author

thanks. I didn't know new commits were silent.

abergeron merged commit f036aef into Theano:master Apr 23, 2018
jvesely deleted the cuda_test branch April 24, 2018 15:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL