FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Upgrade to Python 3.8 by simon-graham · Pull Request #1 · ThomasMatern/cefpython · GitHub

Repository navigation

Upgrade to Python 3.8 - #1

Merged
ThomasMatern merged 3 commits into
ThomasMatern:masterfrom
simon-graham:master
Dec 11, 2020
Merged

ThomasMatern merged 3 commits into
ThomasMatern:masterfrom
simon-graham:master

Conversation

Copy link
Copy Markdown

Upstream cefpython still doesn't support Python 3.8. However there is an open PR for it: cztomczak#546. I've incorporated bits of that here, plus a few more additions.

Comment thread tools/automate.py
setattr(Options, key2, value)

Options.tools_dir = os.path.dirname(os.path.realpath(__file__))
Options.tools_dir = os.path.dirname(os.path.abspath(__file__))

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The behaviour of realpath on Windows changed in Python 3.8. When building on a subst-ed drive, it works out the real path on the original drive and folder. This was breaking our subst-ed build_scripts build. Changing to abspath resolves the issue.

ThomasMatern merged commit bc73903 into ThomasMatern:master Dec 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL