Repository navigation
perf: size the Gizmo clone map after the previous clone - #2729
Open
larsbeck wants to merge 2 commits into
Open
larsbeck wants to merge 2 commits into
larsbeck wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
The generated cloner started every clone with a default-sized IdentityHashMap, so cloning a 110k-entity solution rehashed the map about a dozen times; that was ~9% of each clone. FieldAccessingSolutionCloner already sizes its map from earlier clones. The generated cloner now keeps the size of its previous clone map in an instance field and starts the next map at that size. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DmFY9fXcywg9CE9ufNXt5f
larsbeck
marked this pull request as ready for review
October 6, 2026 13:08
larsbeck
requested review from
Christopher-Chianelli and
triceo
as code owners
October 6, 2026 13:08
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The new shared mutable field must preserve the cloner’s thread-safety contract.
Review effort: Balanced
Findings: 1
Optimizes Gizmo solution cloning by sizing each clone map from the previous clone.
Changes:
- Tracks the previous clone’s object count.
- Pre-sizes subsequent IdentityHashMap instances.
| File | Description |
|---|---|
| GizmoSolutionClonerImplementor.java | Adds adaptive clone-map sizing. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sorry, something went wrong.
SolutionCloner implementations must be thread-safe after initialization, because partitioned search shares one cloner between part threads. FieldAccessingSolutionCloner keeps its size hint in an AtomicInteger; the generated cloner now declares its field volatile. The hint is only written, never read and modified, so visibility is all it needs. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XmKTGxVTeDoPGmxW4jmxKV
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused optimization is correct, thread-safe, and consistent with existing cloner behavior.
Review effort: Balanced
Findings: None
Sorry, something went wrong.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
At least 1 approving review is required to merge this pull request.
Assignees
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Gizmo-generated solution cloner started every clone with a default-sized IdentityHashMap. Cloning a large solution
therefore rehashed the map about a dozen times per clone, and a clone happens on every new best solution.
FieldAccessingSolutionCloner already sizes its map from earlier clones; the generated cloner now does the same: it keeps
the size of its previous clone map in an instance field and starts the next map at that size.
Measured in CPU profiles (JFR, solver thread during local search):
in best-solution cloning.
This was part of a field service routing benchmark on the staging platform (model changes:
TimefoldAI/timefold-field-service-routing#1519), together with the identity-set clear fix that is now on main
(#2726).
🤖 Generated with Claude Code
https://claude.ai/code/session_01XmKTGxVTeDoPGmxW4jmxKV