FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Integrated an SSLSocketChannel class that allows wss support by fomojola · Pull Request #101 · TooTallNate/Java-WebSocket · GitHub

/ Java-WebSocket Public

Integrated an SSLSocketChannel class that allows wss support - #101

Merged
Davidiusdadi merged 2 commits into
TooTallNate:masterfrom
fomojola:master
Jul 12, 2012
ConversationCommits (2)ChecksFiles changed
Merged

Integrated an SSLSocketChannel class that allows wss support#101
Davidiusdadi merged 2 commits into
TooTallNate:masterfrom
fomojola:master

Conversation

fomojola commented Jun 11, 2012

Copy link
Copy Markdown

I integrated an SSLSocketChannel class (taken from the jFxp project at http://jfxp.sourceforge.net/ with permission by the author, Alexander Kout) and modified the WebSocketImpl to allow the use of that instead of a standard SocketChannel.

Also added a simple SSL example that uses a self-signed certificate. The example/SSLServer.java includes a really simple test case that uses a keystore generated using keytool (the keytool syntax is present in that file as a comment, as well as the keystore loading code required).

Femi Omojola added 2 commits June 10, 2012 04:12
Switched to source/target 1.5 in the build.xml (fixes Android deploym…
b2424c1 
…ent errors: see http://code.google.com/p/android/issues/detail?id=22970).

Added the SSLSocketChannel file, and modified the WebSocketImpl to support its use.
Added an example that shows how it would be used.
Rebuild the distribution output.
Updated the SSLSocketChannel.java file to include the attribution.
0a4a98c

Davidiusdadi commented Jun 12, 2012

Copy link
Copy Markdown
Collaborator

@fomojola thank you very much!

I will approach "merging" as soon as i can.

Davidiusdadi added a commit to Davidiusdadi/Java-WebSocket that referenced this pull request Jun 17, 2012
merged conflicted branch 'master' of https://github.com/fomojola/Java…
0710ad1 
…-WebSocket (TooTallNate#101)

Davidiusdadi commented Jun 18, 2012

Copy link
Copy Markdown
Collaborator

@fomojola how did you make your browsers accept the certificate?

fomojola commented Jun 18, 2012

Copy link
Copy Markdown
Author

You either have to use a properly chained cert or it is actually moderately painful: you basically have to visit the IP address using a regular https URL. The browser will prompt you with the usual security warnings and you have to accept the warning and create a security exception, and then it works after that.

Very sub-optimal, but unfortunately no options.

Davidiusdadi merged commit 0a4a98c into TooTallNate:master Jul 12, 2012
Davidiusdadi reviewed Jul 18, 2012
View reviewed changes
Comment thread example/SSLServer.java

Davidiusdadi Jul 18, 2012

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@fomojola I am just testing around with ssl trying to simplify things if possible: 98f4a3c

And i am not sure what the 'handle' is for...? It seems to limit the number of simultaneous connections...

But even when i remove the handle as you see in my code my firefox somehow fails to create more that one ssl connection to the example server at a time.

I am probably missing some basic mechanic...

Do you have an explanation for that behaviour?

fomojola Jul 19, 2012

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

You are right: handle was basically a remnant of my application that made it into the test file, since in my app I only allowed 1 connection at a time.
Creating multiple connections should be just fine: just strip out all references to handle and use arg0. I'm not sure what the default backlog is: I think it is 50 or something, but the base WebSocketServer doesn't set it when calling bind, so there may be something there that prevents multiple connections.

vikasjayaram commented Aug 21, 2012

Copy link
Copy Markdown

Does the WebSocketClient.java support wss? If yes, how to configure this?

Davidiusdadi commented Aug 21, 2012

Copy link
Copy Markdown
Collaborator

WebSocketClient.java and WebSocketServer.java do not care if you use ws or wss.
The WebSocketFactory allows to use custom websocket and channel objects and can therefore be used put an ssl channel in place.

SSLServer.java shows how to do that.

Please also consider #111 and https://github.com/TooTallNate/Java-WebSocket#wss-support.

mkuklis mentioned this pull request Aug 1, 2013
Merged

mparis commented Apr 11, 2014

Copy link
Copy Markdown

Hello,
I am working with WSS and it works well ;).
I have got it downloading the source code and installing it in local with maven, but I want to use Maven Central dependency (http://mvnrepository.com/artifact/org.java-websocket/Java-WebSocket).
The problem is that the current version is 1.3.0 and WSS is available in 1.3.1-SNAPSHOT version.
As I see, the code is stable since few months ago. So, is it possible to deploy a new release to Maven Central?

blunden commented May 17, 2015

Copy link
Copy Markdown

I agree with @mparis, it would be great if you could update the outdated maven central release. Lots of developers prefer to pull down their dependencies from there.

mfsi-ankitb commented Sep 10, 2015

Copy link
Copy Markdown

Actually yes, I too agree with @blunden, can you guys please update the maven central.
I am on live project and really need to use WebSockets having WSS enabled with lollipop.

blunden commented Sep 11, 2015

Copy link
Copy Markdown

@mfsi-ankitb The issue might be that it still has problems with working on both 5.0 and earlier versions. See #293

mfsi-ankitb commented Sep 11, 2015

Copy link
Copy Markdown

@blunden I tried using Java-WebSocket with the latest source code, and it is working for me on lollipop with WSS (using default SSLcontext).

blunden commented Sep 11, 2015

Copy link
Copy Markdown

@mfsi-ankitb Oh, really? Did you confirm that it works with earlier Android versions too?

I personally switched to a different lib for that issue. I know of others who would be interested to know that it has been fixed though.

mfsi-ankitb commented Sep 11, 2015

Copy link
Copy Markdown

@blunden Yes, the connection opens and I am able to send and receive messages (checked in 5.0 and 4.1.1). But, facing some problems like connection breaks (doesn't connect back) when Internet Connectivity drops and reconnect again. And I can't connect back with same client once disconnect is triggered.

blunden commented Sep 11, 2015

Copy link
Copy Markdown

@mfsi-ankitb Thanks for the confirmation!

Yeah, you will need to recreate the WebSocket related objects. That seems to be the case in many WebSocket libraries. Perhaps you can reconnect in some onWebSocketError-like method?

maakolk pushed a commit to maakolk/Java-WebSocket that referenced this pull request Mar 5, 2017
merged conflicted branch 'master' of https://github.com/fomojola/Java…
79dc0f5 
…-WebSocket (TooTallNate#101)
Gjum mentioned this pull request Apr 14, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL