ServerContainer adjustments - #2
Merged
Tranquility2 merged 2 commits intoJun 17, 2024
Merged
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
…refactor * fix the docs so that we can mark DbContainer as deprecated for removal * add a warning to ServerContainer just in case it is actually possible to move it out of core * use glob for modules/index.rst * clean up the table of contents so that deprecated classes do not appear on the front page * prepare to refactor the dockerimage stuff with the same class name/structure as Java (DockerImageName, ImageFromDockerfile)
Copy link
Copy Markdown
Author
|
additionally, had to make httpx not optional as it was referenced in a doctest |
Sorry, something went wrong.
Copy link
Copy Markdown
Owner
|
This is nice, I fully understand the needs to actually be using "DockerImage", my implementation was wrong to use the image file directly.. public GenericContainer dslContainer = new GenericContainer(
new ImageFromDockerfile()
.withFileFromString("folder/someFile.txt", "hello") |
Sorry, something went wrong.
Tranquility2
approved these changes
Jun 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
some additional thoughts, maybe ServerContainer direction should be clarified - its for FastAPI/Lambda module - in the class's doc string.
Additionally I want to make DockerImage and image as string more interchangeable, not just in servercontainer but everywhere, similar to how python has os.PathLike we should have DockerImageName type which includes DockerImage and str - https://java.testcontainers.org/features/creating_images/