Allow jobs to perform a pre-run check and be requeued - #3
Merged
iniq merged 1 commit intoMar 7, 2013
Merged
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
There are intstances (for example when an account is in maintenance mode) that it would be unwise to actually perform a queued task. Only the task knows what those conditions are for itself, so we delegate the job of knowing that to the task in the canRun() method. But now we have three outcomes for a job: Done, Failed, and Couldn't run. Add a new method to the QueuedTask Model to support requeuing a job that isn't failed.
iniq
added a commit
that referenced
this pull request
Mar 7, 2013
Allow jobs to perform a pre-run check and be requeued
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are intstances (for example when an account is in maintenance mode) that
it would be unwise to actually perform a queued task. Only the task knows what
those conditions are for itself, so we delegate the job of knowing that to the
task in the canRun() method.
But now we have three outcomes for a job: Done, Failed, and Couldn't run. Add a
new method to the QueuedTask Model to support requeuing a job that isn't
failed.