fix sync try/catch re-throw and return handling - #1726
Open
pilaoda wants to merge 4 commits into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…ly handle returns and re-throws (test): - enable previously skipped re-throw tests - add tests for complex try-catch-finally return and throw scenarios
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… tryCall Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Extract duplicated return-if-has-return-or-error into a module-level helper. Expand the elseBranch ternary into an explicit if/else with comments for each case (non-empty catch, no catch, empty catch). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The previous sync try/catch implementation had a fundamental issue: the catch block was not wrapped in pcall, so if catch itself threw an error, it would bypass the finally block and propagate as an unhandled Lua error instead of being re-thrown after finally completes — diverging from JavaScript semantics.
Fixing this required rewriting the sync transformTryStatement to:
This unified architecture also simplifies adding break/continue support inside try/catch (see follow-up PR).