FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix kubectl cluster-info dump command and add test coverage by GulajavaMinistudio · Pull Request #139 · TypescriptID/NativeScript · GitHub

Fix kubectl cluster-info dump command and add test coverage - #139

Merged
GulajavaMinistudio merged 1 commit into
TypescriptID:masterfrom
NativeScript:master
Feb 14, 2019
Merged

GulajavaMinistudio merged 1 commit into
TypescriptID:masterfrom
NativeScript:master

Conversation

Copy link
Copy Markdown

… frame (NativeScript#6857)

  • feat(HMR): apply changes in page styles at runtime

  • fix: livesync tests

  • test: changeCssFile method

  • refactor: address comments

Add a comment.
Update let to const.
Update changesCssFile test.

  • test: add an assert

PR Checklist

What is the current behavior?

What is the new behavior?

Fixes/Implements/Closes #[Issue Number].

… frame (#6857)

* feat(HMR): apply changes in page styles at runtime

* fix: livesync tests

* test: changeCssFile method

* refactor: address comments

Add a comment.
Update `let` to `const`.
Update `changesCssFile` test.

* test: add an assert
GulajavaMinistudio merged commit 36f1dea into TypescriptID:master Feb 14, 2019
GulajavaMinistudio pushed a commit that referenced this pull request Mar 21, 2019
As requested in ST 1341351, this PR replaces the throw if `files` is null.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL