FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: improve fetch-schema logging and platform support by JFrankfurt · Pull Request #6191 · Uniswap/interface · GitHub

Repository navigation

fix: improve fetch-schema logging and platform support - #6191

Merged
JFrankfurt merged 2 commits into
Uniswap:mainfrom
JFrankfurt:patch-fetch-schema
Mar 22, 2023
Merged

JFrankfurt merged 2 commits into
Uniswap:mainfrom
JFrankfurt:patch-fetch-schema

Conversation

Copy link
Copy Markdown
Contributor
  • uses npx instead of relying on the package already being present
  • uses node's fs package instead of tee to write to disk
  • logs error if there is one

JFrankfurt requested a review from cartcrom March 20, 2023 16:12

vercel Bot commented Mar 20, 2023 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
interface ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 20, 2023 at 4:32PM (UTC)

JFrankfurt requested a review from a team March 20, 2023 16:12

Copy link
Copy Markdown

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (6fee37c) 14.61% compared to head (6fdf226) 14.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6191      +/-   ##
==========================================
- Coverage   14.61%   14.59%   -0.02%     
==========================================
  Files         413      413              
  Lines       12898    12898              
  Branches     4496     4496              
==========================================
- Hits         1885     1883       -2     
- Misses      11005    11007       +2     
  Partials        8        8              
Impacted Files Coverage Δ
src/hooks/usePoolTickData.ts 0.00% <ø> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

JFrankfurt requested review from a team and vm and removed request for a team and cartcrom March 20, 2023 16:37

just-toby left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

nice

JFrankfurt merged commit cee19ae into Uniswap:main Mar 22, 2023
JFrankfurt deleted the patch-fetch-schema branch March 22, 2023 15:14

This branch was successfully deployed

1 active deployment
Preview — 1c18aeb9 Deployed Mar 20, 2023 by vercel[bot]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL