FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Buffer movement using h,j,k,l by danielo515 · Pull Request #148 · VSpaceCode/VSpaceCode · GitHub

Buffer movement using h,j,k,l - #148

Merged
stevenguh merged 4 commits into
VSpaceCode:masterfrom
danielo515:patch-1
Dec 15, 2020
Merged

stevenguh merged 4 commits into
VSpaceCode:masterfrom
danielo515:patch-1

Conversation

Copy link
Copy Markdown
Contributor

Fixes #146

This adds buffer handling using lowercase h,j,k,l keys

Comment thread package.json Outdated

stevenguh left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We sort the keys by lower and alpha order and then upper case, can you move the keys to the right order? Also can you update CHANGELOG as well. Thank you :)

danielo515 commented Dec 15, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

We sort the keys by lower and alpha order and then upper case, can you move the keys to the right order? Also can you update CHANGELOG as well. Thank you :)

Fixed the keys order.
How do you update the changelog? You do it manually or is there any CLI that you use?
Should I bump a minor version then?

-- EDIT: --
I think I did it correctly, can you check again?

Comment thread package.json Outdated

Copy link
Copy Markdown
Member

Fixed the keys order.
How do you update the changelog? You do it manually or is there any CLI that you use?
Should I bump a minor version then?

-- EDIT: --
I think I did it correctly, can you check again?

Thank you for fixing the order and adding the CHANGELOG. Yeah we manually add the unreleased change in the change log, and I think you did it :) Once you fixed the bogus new line character, I will merge this.

stevenguh merged commit 6034818 into VSpaceCode:master Dec 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Why default to uppercase letters for buffer movement?

2 participants


Back | FazBrowse Home | New Git URL