Change m g d to 'Go to declaration' for Python major mode - #411
niontrix wants to merge 1 commit into
Conversation
Sorry, something went wrong.
`m g d` is a duplication of `m g g` in Python major mode, so fixed that.
|
What I wrote in #410 (comment) is still valid 👍 |
Sorry, something went wrong.
|
Maybe :) but it wasn't my intention to change m g g. I just wanted to fix the duplication. Can you merge my PR, please? |
Sorry, something went wrong.
|
@marcoieni can you please merge my PR or do you want to retain the duplication? (which would not make sense in my mind) |
Sorry, something went wrong.
|
I don't want to merge this pr because of my comment in the other pr. If another maintainer wants to review this and merge, I'm fine with it |
Sorry, something went wrong.
|
In cpp major mode bindings there already is precedent that m g d is used for "Go to declaration". So why keep the duplication for Python? Yes, you are right in so far that this should be changed for all major modes in consequence so the user has a uniform experience. And if it's required I'll gladly make a PR for the rest of them. But why would it make sense to keep a duplication that serves no useful function instead of providing another useful keybinding? |
Sorry, something went wrong.
|
I don't have the capacity of reading your response and dealing with this PR, sorry |
Sorry, something went wrong.
|
@vic, @joefiorini, @mvzink could any of you please take a look at this PR? |
Sorry, something went wrong.
m g d is a duplication of m g g in Python major mode, so I fixed that.
KR