Fix DisableRecording carrying over to later pooled leases - #1072
Merged
SimonCropp merged 1 commit intoSep 23, 2026
Merged
SimonCropp merged 1 commit into
SimonCropp merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
DisableRecording stored ContextId.InstanceId, which a pooled context keeps when it is returned to the pool, so recording stayed disabled for every later lease of that instance. It now stores the whole ContextId, which includes the lease. The ids are also held in a ConcurrentDictionary instead of a ConcurrentBag. ConcurrentBag.Contains copies the bag under a lock, and it ran for every command: about 43 us per command once 1,000 contexts had been disabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DisableRecording stored ContextId.InstanceId, which a pooled context keeps when it is returned to the pool, so recording stayed disabled for every later lease of that instance. It now stores the whole ContextId, which includes the lease.
The ids are also held in a ConcurrentDictionary instead of a ConcurrentBag. ConcurrentBag.Contains copies the bag under a lock, and it ran for every command: about 43 us per command once 1,000 contexts had been disabled.